ableegoldman commented on code in PR #18111:
URL: https://github.com/apache/kafka/pull/18111#discussion_r1877399075
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/StreamStreamJoinNode.java:
##########
@@ -198,16 +158,6 @@ public StreamStreamJoinNodeBuilder<K, V1, V2, VR>
withOuterJoinWindowStoreBuilde
return this;
}
- public StreamStreamJoinNodeBuilder<K, V1, V2, VR> withJoined(final
Joined<K, V1, V2> joined) {
Review Comment:
ah, meant to leave a comment about this. no, was not called or used before
this (the Joined was never invoked, only used for logging, but since we didn't
ever set it, nothing was being logged to begin with 🤷♀️ )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
