mimaison opened a new pull request, #18136:
URL: https://github.com/apache/kafka/pull/18136

   This removes `transaction-coordinator` as a dependency of `storage`. This 
prevented making `transaction-coordinator` depend on `coordinator-common` 
because `coordinator-common` itself depends on `storage` thus making a loop. 
`transaction-coordinator` was only used in `storage` tests to get one constant.
   
   The new Serde, `TransactionCoordinatorRecordSerde`, mimics 
`GroupCoordinatorRecordSerde` and is also used in `DumpLogSegments` instead of 
`TransactionLog`. Following this PR, we will now be able to move 
`DumpLogSegments` to `tools` as `TransactionLog` was the last class it depended 
onto from `core`.
   
   We should be able to refactor `TransactionLog` to use 
`TransactionCoordinatorRecordSerde`, or even completely replace it. But let's 
do that in follow up PRs.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to