[ 
https://issues.apache.org/jira/browse/KAFKA-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904888#comment-17904888
 ] 

David Jacot commented on KAFKA-18206:
-------------------------------------

[~brandboat] That's right. However, I am not sure whether we should call 
setFeature from the embedded class. My advice is to look at how we did it in 
the other integration tests (e.g. in RaftClusterInstance). It would be great if 
we could actually unify the approaches. Regarding the features, it should set 
all the default features (see RaftClusterInstance).

> EmbeddedKafkaCluster must set features
> --------------------------------------
>
>                 Key: KAFKA-18206
>                 URL: https://issues.apache.org/jira/browse/KAFKA-18206
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: David Jacot
>            Assignee: Kuan Po Tseng
>            Priority: Blocker
>             Fix For: 4.0.0
>
>
> The EmbeddedKafkaCluster classes respectively used by Streams and Connect 
> relies on 
> KafkaClusterTestKit. We just found out that they do not set the features at 
> all. They should.
>  
> The other integration tests rely on classes wrapping KafkaClusterTestKit and 
> they take care of setting the features. This is not ideal. I wonder whether 
> we could push that functionality to KafkaClusterTestKit.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to