mjsax commented on code in PR #18115:
URL: https://github.com/apache/kafka/pull/18115#discussion_r1880936730
##########
streams/src/main/java/org/apache/kafka/streams/internals/AutoOffsetResetInternal.java:
##########
@@ -31,7 +30,9 @@ public AutoOffsetResetInternal(final AutoOffsetReset
autoOffsetReset) {
public StrategyType offsetResetStrategy() {
return offsetResetStrategy;
}
- public Optional<Duration> duration() {
- return duration;
+
+ @SuppressWarnings("all")
Review Comment:
Yeah... not happy about this either... Could not find a dedicate suppress
for this warning when accessing an Optional w/o `isPresent()` check... (What we
do on purpose here...)
Given that the method is just a one-liner, I thought it should be ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
