ableegoldman commented on code in PR #18149:
URL: https://github.com/apache/kafka/pull/18149#discussion_r1881209428
##########
streams/src/test/java/org/apache/kafka/streams/StreamsBuilderTest.java:
##########
@@ -1747,6 +1747,30 @@ public void
shouldWrapProcessorsForMaterializedSourceTable() {
assertThat(counter.numConnectedStateStores(), CoreMatchers.is(1));
}
+ @Test
+ public void shouldWrapProcessorsForToTable() {
Review Comment:
I don't think we need a new test for this, it's covered by
`shouldWrapProcessorsForStatelessOperators` right?
If we want to split things up into individual tests then imo we should have
a stateless KStream operators and KTable operators -- that is, remove the
.toTable().filter().toStream() from shouldWrapProcessorsForStatelessOperators
and have two unit tests: this one, plus a new one for `KTable#filter` (once we
implement that cc @rodesai )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]