mjsax commented on code in PR #18160:
URL: https://github.com/apache/kafka/pull/18160#discussion_r1882788976
##########
tools/src/test/java/org/apache/kafka/tools/AbstractResetIntegrationTest.java:
##########
@@ -406,6 +408,7 @@ protected boolean tryCleanGlobal(final boolean
withIntermediateTopics,
final Properties cleanUpConfig = new Properties();
cleanUpConfig.put(ConsumerConfig.HEARTBEAT_INTERVAL_MS_CONFIG, 100);
cleanUpConfig.put(ConsumerConfig.SESSION_TIMEOUT_MS_CONFIG,
Integer.toString(CLEANUP_CONSUMER_TIMEOUT));
+ cleanUpConfig.put(ConsumerConfig.GROUP_PROTOCOL_CONFIG,
GroupProtocol.CLASSIC.name);
Review Comment:
I am actually wondering if this is the right fix? It seem, we should change
`StreamsResetter` and hard-code the "classic" protocol there (and guard it from
being overwritten by the user).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
