jsancio commented on code in PR #17807:
URL: https://github.com/apache/kafka/pull/17807#discussion_r1882968765
##########
clients/src/main/resources/common/message/VoteRequest.json:
##########
@@ -35,18 +36,20 @@
"versions": "0+", "about": "The partition data.", "fields": [
{ "name": "PartitionIndex", "type": "int32", "versions": "0+",
"about": "The partition index." },
- { "name": "CandidateEpoch", "type": "int32", "versions": "0+",
- "about": "The bumped epoch of the candidate sending the
request."},
- { "name": "CandidateId", "type": "int32", "versions": "0+",
"entityType": "brokerId",
- "about": "The replica id of the voter sending the request."},
- { "name": "CandidateDirectoryId", "type": "uuid", "versions":
"1+", "ignorable": true,
- "about": "The directory id of the voter sending the request." },
+ { "name": "ReplicaEpoch", "type": "int32", "versions": "0+",
+ "about": "The epoch of the voter sending the request"},
+ { "name": "ReplicaId", "type": "int32", "versions": "0+",
"entityType": "brokerId",
+ "about": "The replica id of the voter sending the request"},
+ { "name": "ReplicaDirectoryId", "type": "uuid", "versions": "1+",
"ignorable": true,
+ "about": "The directory id of the voter sending the request" },
{ "name": "VoterDirectoryId", "type": "uuid", "versions": "1+",
"ignorable": true,
- "about": "The ID of the voter sending the request."},
+ "about": "The directory id of the voter receiving the request"},
{ "name": "LastOffsetEpoch", "type": "int32", "versions": "0+",
"about": "The epoch of the last record written to the metadata
log."},
{ "name": "LastOffset", "type": "int64", "versions": "0+",
- "about": "The offset of the last record written to the metadata
log."}
+ "about": "The offset of the last record written to the metadata
log."},
Review Comment:
Sounds good. I also don't like the field name `LastOffset` but I can fix
that in a minor PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
