chia7712 commented on code in PR #17741:
URL: https://github.com/apache/kafka/pull/17741#discussion_r1885463533


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java:
##########
@@ -82,6 +87,11 @@ public class ConnectorConfig extends AbstractConfig {
                     " or use \"FileStreamSink\" or \"FileStreamSinkConnector\" 
to make the configuration a bit shorter";
     private static final String CONNECTOR_CLASS_DISPLAY = "Connector class";
 
+    public static final String CONNECTOR_VERSION = "connector." + 
WorkerConfig.PLUGIN_VERSION_SUFFIX;

Review Comment:
   @snehashisp Thanks for this great patch. I have one small comment: It seems 
we are using `connector.plugin.version` instead of `connector.version`, 
correct? If so, could you please update the KIP accordingly?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to