Yunyung commented on code in PR #18204:
URL: https://github.com/apache/kafka/pull/18204#discussion_r1886668152
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java:
##########
@@ -548,9 +548,9 @@ public Optional<Set<Integer>> partitions(final String
topic, final String key, f
final Map<TopicPartition, Long> offsets = collector.offsets();
// with mock producer without specific partition, we would use default
producer partitioner with murmur hash
Review Comment:
We use RoundRobinPartitioner instead of "default producer partitioner with
murmur hash"; should we update the comment?
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/RecordCollectorTest.java:
##########
@@ -602,9 +602,9 @@ public void
shouldUseDefaultPartitionerAsPartitionReturnsEmptyOptional() {
final Map<TopicPartition, Long> offsets = collector.offsets();
// with mock producer without specific partition, we would use default
producer partitioner with murmur hash
Review Comment:
ditto, same for the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
