AndrewJSchofield commented on code in PR #18209:
URL: https://github.com/apache/kafka/pull/18209#discussion_r1887272452
##########
checkstyle/suppressions.xml:
##########
@@ -288,6 +288,8 @@
files="VerifiableConsumer.java"/>
<suppress id="dontUseSystemExit"
files="VerifiableProducer.java"/>
+ <suppress id="dontUseSystemExit"
+ files="VerifiableShareGroup.java"/>
Review Comment:
`VerifiableShareGroup` doesn't exist. Do you mean `VerifiableShareConsumer`?
##########
tests/kafkatest/services/verifiable_client.py:
##########
@@ -142,10 +142,10 @@
def create_verifiable_client_implementation(context, parent):
"""Factory for generating a verifiable client implementation class instance
- :param parent: parent class instance, either VerifiableConsumer or
VerifiableProducer
+ :param parent: parent class instance, either VerifiableConsumer,
VerifiableProducer or VerifiableShareGroup
Review Comment:
These references to `VerifiableShareGroup` and `ShareGroup` should probably
be `VerifiableShareConsumer` and `ShareConsumer`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
