[ 
https://issues.apache.org/jira/browse/KAFKA-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16690043#comment-16690043
 ] 

Samuel Hawker edited comment on KAFKA-5946 at 11/16/18 9:58 PM:
----------------------------------------------------------------

Hi, I notice this has not seen any activity in many months, if 
[~tanvijaywant31] is not still working on it, can I pick up the ticket? :)

Just a few questions - I understand the part about renaming the class to 
connClass, but what do you mean by standardise? In this context does it just 
mean extend the class with these extra fields?
(The class I am referring to is ConnectorType)


was (Author: samuel hawker):
Hi, I notice this has not seen any activity in many months, if 
[~tanvijaywant31] is not still working on it, can I pick up the ticket? :)

Just a few questions - I understand the part about renaming the class to 
connClass, but what do you mean by standardise? In this context does it just 
mean extend the class with these extra fields?

> Give connector method parameter better name
> -------------------------------------------
>
>                 Key: KAFKA-5946
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5946
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Ted Yu
>            Assignee: Tanvi Jaywant
>            Priority: Major
>              Labels: connector, newbie
>
> During the development of KAFKA-5657, there were several iterations where 
> method call didn't match what the connector parameter actually represents.
> [~ewencp] had used connType as equivalent to connClass because Type wasn't 
> used to differentiate source vs sink.
> [~ewencp] proposed the following:
> {code}
> It would help to convert all the uses of connType to connClass first, then 
> standardize on class == java class, type == source/sink, name == 
> user-specified name.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to