lucasbru commented on code in PR #18228: URL: https://github.com/apache/kafka/pull/18228#discussion_r1889946956
########## group-coordinator/src/main/resources/common/message/StreamsGroupTopologyValue.json: ########## @@ -0,0 +1,74 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// The streams rebalance protocol is in development. This schema is subject to non-backwards-compatible changes. +{ + "type": "data", + "name": "StreamsGroupTopologyValue", + "validVersions": "0", + "flexibleVersions": "0+", + "fields": [ + { "name": "Epoch", "type": "int32", "versions": "0+", + "about": "The epoch of the topology." }, + { "name": "Subtopologies", "type": "[]Subtopology", "versions": "0+", + "about": "The sub-topologies of the streams application.", + "fields": [ + { "name": "SubtopologyId", "type": "string", "versions": "0+", + "about": "String to uniquely identify the subtopology." }, + { "name": "SourceTopics", "type": "[]string", "versions": "0+", + "about": "The topics the topology reads from." }, + { "name": "SourceTopicRegex", "type": "[]string", "versions": "0+", + "about": "Regular expressions identifying topics the subtopology reads from." }, + { "name": "StateChangelogTopics", "type": "[]TopicInfo", "versions": "0+", + "about": "The set of state changelog topics associated with this subtopology." }, + { "name": "RepartitionSinkTopics", "type": "[]string", "versions": "0+", + "about": "The repartition topics the subtopology writes to." }, + { "name": "RepartitionSourceTopics", "type": "[]TopicInfo", "versions": "0+", + "about": "The set of source topics that are internally created repartition topics." }, + { "name": "CopartitionGroups", "type": "[]CopartitionGroup", "versions": "0+", + "about": "A subset of source topics that must be copartitioned.", + "fields": [ + { "name": "SourceTopics", "type": "[]int16", "versions": "0+", + "about": "The topics the topology reads from. Index into the array on the subtopology level." }, + { "name": "SourceTopicRegex", "type": "[]int16", "versions": "0+", + "about": "Regular expressions identifying topics the subtopology reads from. Index into the array on the subtopology level." }, + { "name": "RepartitionSourceTopics", "type": "[]int16", "versions": "0+", + "about": "The set of source topics that are internally created repartition topics. Index into the array on the subtopology level." } + ] + } + ] + } + ], + "commonStructs": [ + { "name": "TopicConfig", "versions": "0+", "fields": [ + { "name": "key", "type": "string", "versions": "0+", + "about": "The key of the topic-level configuration." }, + { "name": "value", "type": "string", "versions": "0+", + "about": "The value of the topic-level configuration," } Review Comment: ends with comma ########## group-coordinator/src/main/resources/common/message/StreamsGroupMetadataKey.json: ########## @@ -0,0 +1,26 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// The streams rebalance protocol is in development. This schema is subject to non-backwards-compatible changes. +{ + "type": "data", + "name": "StreamsGroupMetadataKey", + "validVersions": "17", + "flexibleVersions": "none", + "fields": [ + { "name": "GroupId", "type": "string", "versions": "17", + "about": "The group id." } Review Comment: nit: Probably we should try to use "ID" everywhere in the text, instead of "id". ########## group-coordinator/src/main/resources/common/message/StreamsGroupMemberMetadataValue.json: ########## @@ -0,0 +1,60 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// The streams rebalance protocol is in development. This schema is subject to non-backwards-compatible changes. +{ + "type": "data", + "name": "StreamsGroupMemberMetadataValue", + "validVersions": "0", + "flexibleVersions": "0+", + "fields": [ + { "name": "InstanceId", "versions": "0+", "nullableVersions": "0+", "type": "string", + "about": "The (optional) instance ID for static membership." }, + { "name": "RackId", "versions": "0+", "nullableVersions": "0+", "type": "string", + "about": "The (optional) rack id." }, + { "name": "ClientId", "versions": "0+", "type": "string", + "about": "The client id." }, + { "name": "ClientHost", "versions": "0+", "type": "string", + "about": "The client host." }, + { "name": "RebalanceTimeoutMs", "type": "int32", "versions": "0+", "default": -1, + "about": "The rebalance timeout." }, + Review Comment: not sure if blank lines serve any purpose in this file, maybe remove? ########## group-coordinator/src/main/resources/common/message/StreamsGroupMemberMetadataValue.json: ########## @@ -0,0 +1,60 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +// The streams rebalance protocol is in development. This schema is subject to non-backwards-compatible changes. +{ + "type": "data", + "name": "StreamsGroupMemberMetadataValue", + "validVersions": "0", + "flexibleVersions": "0+", + "fields": [ + { "name": "InstanceId", "versions": "0+", "nullableVersions": "0+", "type": "string", + "about": "The (optional) instance ID for static membership." }, + { "name": "RackId", "versions": "0+", "nullableVersions": "0+", "type": "string", + "about": "The (optional) rack id." }, + { "name": "ClientId", "versions": "0+", "type": "string", + "about": "The client id." }, + { "name": "ClientHost", "versions": "0+", "type": "string", + "about": "The client host." }, + { "name": "RebalanceTimeoutMs", "type": "int32", "versions": "0+", "default": -1, + "about": "The rebalance timeout." }, + + { "name": "TopologyEpoch", "type": "int32", "versions": "0+", + "about": "The epoch of the topology." }, + + { "name": "ProcessId", "type": "string", "versions": "0+", + "about": "Identity of the streams instance that may have multiple consumers." }, + { "name": "UserEndpoint", "type": "Endpoint", "versions": "0+", "nullableVersions": "0+", "default": "null", + "about": "User-defined endpoint for running interactive queries on this instance." }, + { "name": "ClientTags", "type": "[]KeyValue", "versions": "0+", + "about": "Used for rack-aware assignment algorithm." } + ], + "commonStructs": [ + { "name": "Endpoint", "versions": "0+", "fields": [ + { "name": "Host", "type": "string", "versions": "0+", + "about": "host of the endpoint" }, Review Comment: All other "about" fields are capitalized and end with a ".". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
