chia7712 commented on code in PR #18185:
URL: https://github.com/apache/kafka/pull/18185#discussion_r1889982321
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##########
@@ -179,17 +178,23 @@ private synchronized
List<org.apache.logging.log4j.Logger> loggers(String namesp
// visible for testing
org.apache.logging.log4j.Logger lookupLogger(String logger) {
- return LogManager.getLogger(logger);
+ return LogManager.getLogger(isValidRootLoggerName(logger) ?
LogManager.ROOT_LOGGER_NAME : logger);
}
List<org.apache.logging.log4j.Logger> currentLoggers() {
LoggerContext context = (LoggerContext) LogManager.getContext(false);
- Collection<LoggerConfig> loggerConfigs =
context.getConfiguration().getLoggers().values();
- return loggerConfigs.stream()
+ Set<String> loggers = context.getLoggerRegistry().getLoggers()
Review Comment:
it seems we can return the loggers directly:
```java
LoggerContext context = (LoggerContext) LogManager.getContext(false);
return context.getLoggerRegistry().getLoggers()
.stream()
.map(r -> (org.apache.logging.log4j.Logger) r)
.toList();
```
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/Loggers.java:
##########
@@ -179,17 +178,23 @@ private synchronized
List<org.apache.logging.log4j.Logger> loggers(String namesp
// visible for testing
org.apache.logging.log4j.Logger lookupLogger(String logger) {
- return LogManager.getLogger(logger);
+ return LogManager.getLogger(isValidRootLoggerName(logger) ?
LogManager.ROOT_LOGGER_NAME : logger);
}
List<org.apache.logging.log4j.Logger> currentLoggers() {
LoggerContext context = (LoggerContext) LogManager.getContext(false);
- Collection<LoggerConfig> loggerConfigs =
context.getConfiguration().getLoggers().values();
- return loggerConfigs.stream()
+ Set<String> loggers = context.getLoggerRegistry().getLoggers()
Review Comment:
Additionally, the API is expected to return root logger, so we can call
`context.getRootLogger()` to ensure the root logger is created.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
