jolshan commented on code in PR #18264:
URL: https://github.com/apache/kafka/pull/18264#discussion_r1893055574
##########
core/src/test/scala/integration/kafka/api/TransactionsTest.scala:
##########
@@ -801,20 +800,19 @@ class TransactionsTest extends IntegrationTestHarness {
producer.send(TestUtils.producerRecordWithExpectedTransactionStatus(testTopic,
0, "4", "4", willBeCommitted = true))
producer.commitTransaction()
- // Get producerId and epoch after first commit
+ // Second transaction: abort
+ producer.beginTransaction()
+ val successfulFuture =
producer.send(TestUtils.producerRecordWithExpectedTransactionStatus(topic1,
null, "2", "2", willBeCommitted = false))
+ TestUtils.waitUntilTrue(successfulFuture.isDone, "First message of the
second transaction did not complete its send.")
Review Comment:
Oh I missed the continued discussion. I just set the wait on the get to 20
seconds like some of the others in the file. The waitUntilTrue default is 15
seconds so I think this is sufficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
