jolshan commented on code in PR #17687:
URL: https://github.com/apache/kafka/pull/17687#discussion_r1893274813
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionMetadata.scala:
##########
@@ -329,8 +347,12 @@ private[transaction] class TransactionMetadata(val
transactionalId: String,
case _ => txnStartTimestamp
}
- prepareTransitionTo(Ongoing, producerId, producerEpoch, lastProducerEpoch,
txnTimeoutMs,
- (topicPartitions ++ addedTopicPartitions).toSet, newTxnStartTimestamp,
updateTimestamp, clientTransactionVersion)
+ prepareTransitionTo(
+ state = Ongoing,
+ topicPartitions = (topicPartitions ++ addedTopicPartitions),
+ txnStartTimestamp = newTxnStartTimestamp,
+ txnLastUpdateTimestamp = updateTimestamp
Review Comment:
should we include clientTransactionVersion here since it is now passed to
this method too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
