mumrah commented on PR #18284: URL: https://github.com/apache/kafka/pull/18284#issuecomment-2557113789
@m1a2st / @clolov / @FrankYang0529 It looks like #18100 was not up to date with trunk before it was merged. On trunk, 220c578521 builds just fine. On 18100, the last commit 435c3365ff71 (after merging trunk) also builds fine, however this commit was from a week ago. Even though there was a breaking change on trunk, it was not noticed by Git because it conflicted in a more subtle way than just the diff. Since we build the contents of the PR, and not the contents of trunk + PR, errors like this can occur. To avoid it, just be sure to get a green build with a recent trunk before merging. This is a problem we are hoping to solve with the merge queue once it becomes available. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
