ijuma commented on code in PR #18267:
URL: https://github.com/apache/kafka/pull/18267#discussion_r1894552798
##########
core/src/test/scala/integration/kafka/api/ConsumerWithLegacyMessageFormatIntegrationTest.scala:
##########
@@ -113,9 +106,7 @@ class ConsumerWithLegacyMessageFormatIntegrationTest
extends AbstractConsumerTes
prop.setProperty(ProducerConfig.ENABLE_IDEMPOTENCE_CONFIG, "false")
Review Comment:
Shall we remove this property and comment? Also, the topic name should be
updated.
##########
core/src/test/scala/unit/kafka/utils/TestUtils.scala:
##########
@@ -356,12 +355,8 @@ object TestUtils extends Logging {
props
}
- @nowarn("cat=deprecation")
def setIbpAndMessageFormatVersions(config: Properties, version:
MetadataVersion): Unit = {
Review Comment:
We should rename this method.
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##########
@@ -436,7 +375,7 @@ private Optional<Compression> getCompression() {
}
public RecordVersion recordVersion() {
Review Comment:
Shall we remove this method? It doesn't make sense now that we don't have a
log config for record version.
##########
core/src/main/scala/kafka/server/ConfigHandler.scala:
##########
@@ -60,11 +57,9 @@ class TopicConfigHandler(private val replicaManager:
ReplicaManager,
private def updateLogConfig(topic: String,
topicConfig: Properties): Unit = {
val logManager = replicaManager.logManager
- // Validate the configurations.
- val configNamesToExclude = excludedConfigs(topic, topicConfig)
val props = new Properties()
topicConfig.asScala.foreachEntry { (key, value) =>
Review Comment:
Is this code needed at all now?
##########
docs/upgrade.html:
##########
@@ -61,6 +61,8 @@ <h5><a id="upgrade_400_notable"
href="#upgrade_400_notable">Notable changes in 4
</li>
<li>The
<code>org.apache.kafka.clients.producer.internals.DefaultPartitioner</code> and
<code>org.apache.kafka.clients.producer.UniformStickyPartitioner</code> class
was removed.
</li>
+ <li>The <code>log.message.format.version</code> and
<code>message.format.version</code> were removed.
Review Comment:
We should add the word `configs` before `were removed`.
##########
server-common/src/main/java/org/apache/kafka/server/config/ServerTopicConfigSynonyms.java:
##########
@@ -49,8 +49,6 @@ public final class ServerTopicConfigSynonyms {
* both the first and the second synonyms are configured, we will use only
the value of
* the first synonym and ignore the second.
*/
- // Topic configs with no mapping to a server config can be found in
`LogConfig.CONFIGS_WITH_NO_SERVER_DEFAULTS`
Review Comment:
Why did we remove this comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
