brandboat commented on PR #18193: URL: https://github.com/apache/kafka/pull/18193#issuecomment-2557994338
Thank you for the comments, and a special thanks to Chia-Ping for helping with the answer! > However, I agree that the benefit is minimal, as the use case is rare (e.g., upgrading from 0.11 to 0.4 is highly unusual). Therefore, I prefer to add a new test case (same file) that runs the 3.9 server to cover these rare scenarios. This approach would eliminate the numerous if-else conditions in the environment setup. Thanks for the suggestion! I’ll go ahead and extract those conditions into new tests, and if either of you have any further concerns, please feel free to let me know. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
