jayteej commented on code in PR #18080:
URL: https://github.com/apache/kafka/pull/18080#discussion_r1895995008
##########
docs/upgrade.html:
##########
@@ -175,6 +175,9 @@ <h5><a id="upgrade_400_notable"
href="#upgrade_400_notable">Notable changes in 4
</li>
<li>The deprecated
<code>sendOffsetsToTransaction(Map<TopicPartition, OffsetAndMetadata>,
String)</code> method has been removed from the Producer API.
</li>
+ <li>The default value of <code>linger.ms</code> has
been changed from 0ms to 5ms. The impact of this is larger request batches will
be filled by default at the expense of
+ time in the producer. It is generally observed
that values lower than 5ms do not yield any latency benefits due to the IO
overhead of smaller requests.
Review Comment:
Done
##########
clients/src/main/java/org/apache/kafka/clients/producer/ProducerConfig.java:
##########
@@ -93,8 +93,9 @@ public class ProducerConfig extends AbstractConfig {
+ "<p>"
+ "Note: This setting gives
the upper bound of the batch size to be sent. If we have fewer than this many
bytes accumulated "
+ "for this partition, we
will 'linger' for the <code>linger.ms</code> time waiting for more records to
show up. "
- + "This
<code>linger.ms</code> setting defaults to 0, which means we'll immediately
send out a record even the accumulated "
- + "batch size is under this
<code>batch.size</code> setting.";
+ + "This
<code>linger.ms</code> setting defaults to 5, which means we'll wait 5ms for
the accumulated "
+ + "<code>batch.size</code> to
fill as much as it can in this timeframe. This value previously defaulted"
+ + "to 0, but over time we
have observed that the IO overhead caused by smaller batches negates any
latency gains.";
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
