chia7712 commented on code in PR #18310:
URL: https://github.com/apache/kafka/pull/18310#discussion_r1896715858
##########
core/src/main/scala/kafka/server/ControllerServer.scala:
##########
@@ -155,6 +156,11 @@ class ControllerServer(
() => featuresPublisher.features()
)
+ // metrics will be set to null when closing a controller, so we should
recreate it for testing
+ if (sharedServer.metrics == null){
Review Comment:
Should we do similar fix to BrokerServer? It uses the metrics as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
