ijuma commented on code in PR #18296:
URL: https://github.com/apache/kafka/pull/18296#discussion_r1896832320
##########
clients/src/test/java/org/apache/kafka/test/TestUtils.java:
##########
@@ -583,19 +583,6 @@ public static <T extends Throwable> void
assertFutureThrows(
assertEquals(expectedMessage, receivedException.getMessage());
}
- public static void assertFutureError(Future<?> future, Class<? extends
Throwable> exceptionClass)
- throws InterruptedException {
- try {
- future.get();
- fail("Expected a " + exceptionClass.getSimpleName() + " exception,
but got success.");
- } catch (ExecutionException ee) {
- Throwable cause = ee.getCause();
- assertEquals(exceptionClass, cause.getClass(),
Review Comment:
The remaining method has a less useful message, it doesn't include the
expected class. Perhaps we should address it as part of this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
