ijuma commented on code in PR #17731:
URL: https://github.com/apache/kafka/pull/17731#discussion_r1896838004
##########
core/src/test/scala/unit/kafka/network/SocketServerTest.scala:
##########
@@ -274,8 +274,8 @@ class SocketServerTest {
sendRequest(plainSocket, apiVersionRequestBytes(clientId, version))
var receivedReq = receiveRequest(server.dataPlaneRequestChannel)
- assertEquals(ClientInformation.UNKNOWN_NAME_OR_VERSION,
receivedReq.context.clientInformation.softwareName)
- assertEquals(ClientInformation.UNKNOWN_NAME_OR_VERSION,
receivedReq.context.clientInformation.softwareVersion)
+ assertEquals(expectedClientSoftwareName,
receivedReq.context.clientInformation.softwareName)
+ assertEquals(expectedClientSoftwareVersion,
receivedReq.context.clientInformation.softwareVersion)
Review Comment:
The comment above these lines is wrong with this change. I assume there was
a reason for the original behavior though - @dajac @rajinisivaram do you recall?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
