chia7712 commented on code in PR #18282:
URL: https://github.com/apache/kafka/pull/18282#discussion_r1897164693
##########
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##########
@@ -1020,9 +1011,6 @@ private Future<RecordMetadata> doSend(ProducerRecord<K,
V> record, Callback call
if (result.abortForNewBatch) {
int prevPartition = partition;
- // IMPORTANT NOTE: the following onNewBatch and partition
calls should not interrupted to allow
- // the custom partitioner to correctly track its state
- onNewBatch(record.topic(), cluster, prevPartition);
Review Comment:
we don't need the path of "abortOnNewBatch", right? If so, could you please
do a bit refactor for it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
