Re: [PR] KAFKA-18315: Fix to Kraft or remove tests associate with Zk Broker config in DynamicBrokerConfigTest, ReplicaManagerTest, DescribeTopicPartitionsRequestHandlerTest, KafkaConfigTest [kafka]

[via GitHub]

chia7712 commented on code in PR #18269:
URL: https://github.com/apache/kafka/pull/18269#discussion_r1899107635


##########
core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala:
##########
@@ -733,82 +708,82 @@ class KafkaConfigTest {
 
   @Test
   def testLogRollTimeNoConfigProvided(): Unit = {
-    val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port 
= 8181)
+    val props = TestUtils.createBrokerConfig(0, null, port = 8181)
 
     val cfg = KafkaConfig.fromProps(props)
     assertEquals(24 * 7 * 60L * 60L * 1000L, cfg.logRollTimeMillis             
                                                                                
                                                                                
                        )
   }
 
   @Test
   def testDefaultCompressionType(): Unit = {
-    val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port 
= 8181)
+    val props = TestUtils.createBrokerConfig(0, null, port = 8181)
     val serverConfig = KafkaConfig.fromProps(props)
     assertEquals(serverConfig.compressionType, "producer")
   }
 
   @Test
   def testValidCompressionType(): Unit = {
-    val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port 
= 8181)
+    val props = TestUtils.createBrokerConfig(0, null, port = 8181)
     props.setProperty("compression.type", "gzip")
     val serverConfig = KafkaConfig.fromProps(props)
     assertEquals(serverConfig.compressionType, "gzip")
   }
 
   @Test
   def testInvalidCompressionType(): Unit = {
-    val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port 
= 8181)
+    val props = TestUtils.createBrokerConfig(0, null, port = 8181)
     props.setProperty(ServerConfigs.COMPRESSION_TYPE_CONFIG, "abc")
     assertThrows(classOf[ConfigException], () => KafkaConfig.fromProps(props))
   }
 
   @Test
   def testInvalidGzipCompressionLevel(): Unit = {
-    val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port 
= 8181)
+    val props = TestUtils.createBrokerConfig(0, null, port = 8181)
     props.setProperty(ServerConfigs.COMPRESSION_TYPE_CONFIG, "gzip")
     props.setProperty(ServerConfigs.COMPRESSION_GZIP_LEVEL_CONFIG, 
(CompressionType.GZIP.maxLevel() + 1).toString)
     assertThrows(classOf[ConfigException], () => KafkaConfig.fromProps(props))
   }
 
   @Test
   def testInvalidLz4CompressionLevel(): Unit = {
-    val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port 
= 8181)
+    val props = TestUtils.createBrokerConfig(0, null, port = 8181)
     props.setProperty(ServerConfigs.COMPRESSION_TYPE_CONFIG, "lz4")
     props.setProperty(ServerConfigs.COMPRESSION_LZ4_LEVEL_CONFIG, 
(CompressionType.LZ4.maxLevel() + 1).toString)
     assertThrows(classOf[ConfigException], () => KafkaConfig.fromProps(props))
   }
 
   @Test
   def testInvalidZstdCompressionLevel(): Unit = {
-    val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port 
= 8181)
+    val props = TestUtils.createBrokerConfig(0, null, port = 8181)
     props.setProperty(ServerConfigs.COMPRESSION_TYPE_CONFIG, "zstd")
     props.setProperty(ServerConfigs.COMPRESSION_ZSTD_LEVEL_CONFIG, 
(CompressionType.ZSTD.maxLevel() + 1).toString)
     assertThrows(classOf[ConfigException], () => KafkaConfig.fromProps(props))
   }
 
   @Test
   def testInvalidInterBrokerSecurityProtocol(): Unit = {
-    val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port 
= 8181)
+    val props = TestUtils.createBrokerConfig(0, null, port = 8181)
     props.setProperty(SocketServerConfigs.LISTENERS_CONFIG, 
"SSL://localhost:0")
     
props.setProperty(ReplicationConfigs.INTER_BROKER_SECURITY_PROTOCOL_CONFIG, 
SecurityProtocol.PLAINTEXT.toString)
     assertThrows(classOf[IllegalArgumentException], () => 
KafkaConfig.fromProps(props))
   }
 
   @Test
   def testEqualAdvertisedListenersProtocol(): Unit = {
-    val props = TestUtils.createBrokerConfig(0, TestUtils.MockZkConnect, port 
= 8181)
-    props.setProperty(SocketServerConfigs.LISTENERS_CONFIG, 
"PLAINTEXT://localhost:9092,SSL://localhost:9093")
-    props.setProperty(SocketServerConfigs.ADVERTISED_LISTENERS_CONFIG, 
"PLAINTEXT://localhost:9092,SSL://localhost:9093")
+    val props = TestUtils.createBrokerConfig(0, null, port = 8181)
+    props.setProperty(SocketServerConfigs.ADVERTISED_LISTENERS_CONFIG, 
"PLAINTEXT://localhost:9092")

Review Comment:
   we should add security map, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org