lucasbru commented on code in PR #18270: URL: https://github.com/apache/kafka/pull/18270#discussion_r1900820302
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/TopologyDescriber.java: ########## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.streams.assignor; + +import java.util.List; +import java.util.NoSuchElementException; + +/** + * The subscribed topic describer is used by the {@link TaskAssignor} to obtain topic and task metadata of the groups topology. + */ +public interface TopologyDescriber { + + /** + * @return The list of subtopologies IDs. + */ + List<String> subtopologies(); + + /** + * The number of tasks for the given subtopology. + * + * @param subtopologyId String identifying the subtopology. + * + * @return The number of tasks corresponding to the given subtopology ID. + * @throws NoSuchElementException if subtopology does not exist in the topology. + */ + int numTasks(String subtopologyId) throws NoSuchElementException; + + /** + * Whether the given subtopology is stateful. + * + * @param subtopologyId String identifying the subtopology. + * @return true if the subtopology is stateful, false otherwise. + */ + boolean isStateful(String subtopologyId); Review Comment: This is only an interface. The mockassingor does not distinguish between stateless and stateful tasks, so it's not used in the test. This will be tested when the interface gets a production implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
