lucasbru commented on code in PR #18307:
URL: https://github.com/apache/kafka/pull/18307#discussion_r1901833490
##########
docs/ops.html:
##########
@@ -2783,9 +2783,14 @@ <h5 class="anchor-heading"><a
id="kafka_streams_client_monitoring" class="anchor
</tr>
<tr>
<td>state</td>
- <td>The state of the Kafka Streams client.</td>
+ <td>The state of the Kafka Streams client as string.</td>
Review Comment:
```suggestion
<td>The state of the Kafka Streams client as a string.</td>
```
##########
docs/ops.html:
##########
@@ -2783,9 +2783,14 @@ <h5 class="anchor-heading"><a
id="kafka_streams_client_monitoring" class="anchor
</tr>
<tr>
<td>state</td>
- <td>The state of the Kafka Streams client.</td>
+ <td>The state of the Kafka Streams client as string.</td>
<td>kafka.streams:type=stream-metrics,client-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>client-state</td>
+ <td>The state of the Kafka Streams client as number
(<code>ordinal()</code> of the corresponding enum).</td>
Review Comment:
```suggestion
<td>The state of the Kafka Streams client as a number
(<code>ordinal()</code> of the corresponding enum).</td>
```
##########
docs/ops.html:
##########
@@ -2808,6 +2818,16 @@ <h5 class="anchor-heading"><a
id="kafka_streams_thread_monitoring" class="anchor
<th>Description</th>
<th>Mbean name</th>
</tr>
+ <tr>
+ <td>state</td>
+ <td>The state of the thread as string.</td>
Review Comment:
```suggestion
<td>The state of the thread as a string.</td>
```
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -835,6 +842,18 @@ <h4><a class="toc-backref"
href="#id40">log.summary.interval.ms</a><a class="hea
</div>
</blockquote>
</div>
+ <div class="section" id="enable-metrics-push">
+ <span id="streams-developer-guide-enable-metrics-push"></span><h4><a
class="toc-backref" href="#id43">enable.metrics.push</a><a class="headerlink"
href="#enable-metrics-push" title="Permalink to this headline"></a></h4>
+ <blockquote>
+ <div>
+ <p>
+ Kafka Streams metrics can be pushed to the brokers similar to
client metrics.
+ Additionally, Kafka Streams allows to enabled/disabled metric
pushing for each embedded client individually.
Review Comment:
```suggestion
Additionally, Kafka Streams allows to enable/disable metric
pushing for each embedded client individually.
```
##########
docs/ops.html:
##########
@@ -2796,6 +2801,11 @@ <h5 class="anchor-heading"><a
id="kafka_streams_client_monitoring" class="anchor
<td>The number of failed stream threads since the start of the Kafka
Streams client.</td>
<td>kafka.streams:type=stream-metrics,client-id=([-.\w]+)</td>
</tr>
+ <tr>
+ <td>recording-level</td>
+ <td>The metric recording level as number (0 = INFO, 1 = DEBUG, 2 =
TRACE).</td>
Review Comment:
```suggestion
<td>The metric recording level as a number (0 = INFO, 1 = DEBUG, 2 =
TRACE).</td>
```
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -591,8 +597,9 @@ <h4><a class="toc-backref"
href="#id27">acceptable.recovery.lag</a><a class="hea
such as attempting to produce a record that is too large. By
default, Kafka provides and uses the <a class="reference external"
href="/{{version}}/javadoc/org/apache/kafka/streams/errors/DefaultProductionExceptionHandler.html">DefaultProductionExceptionHandler</a>
that always fails when these exceptions occur.</p>
- <p>Each exception handler can return a <code>FAIL</code> or
<code>CONTINUE</code> depending on the record and the exception thrown.
Returning <code>FAIL</code> will signal that Streams should shut down and
<code>CONTINUE</code> will signal that Streams
- should ignore the issue and continue processing. If you want
to provide an exception handler that always ignores records that are too large,
you could implement something like the following:</p>
+ <p>An exception handler can return <code>FAIL</code>,
<code>CONTINUE</code>, or <code>RETRY</code> depending on the record and the
exception thrown. Returning <code>FAIL</code> will signal that Streams should
shut down. <code>CONTINUE</code> will signal that Streams
+ should ignore the issue and continue processing. For
<code>RetriableException</code> the handler may retyr <code>RETRY</code> to
tell the runtime to retry sending the failed record (<b>Note:</b> If
<code>RETRY</code> is returned for a non-<code>RetriableException</code>
Review Comment:
```suggestion
should ignore the issue and continue processing. For
<code>RetriableException</code> the handler may return <code>RETRY</code> to
tell the runtime to retry sending the failed record (<b>Note:</b> If
<code>RETRY</code> is returned for a non-<code>RetriableException</code>
```
##########
docs/ops.html:
##########
@@ -2808,6 +2818,16 @@ <h5 class="anchor-heading"><a
id="kafka_streams_thread_monitoring" class="anchor
<th>Description</th>
<th>Mbean name</th>
</tr>
+ <tr>
+ <td>state</td>
+ <td>The state of the thread as string.</td>
+ <td>kafka.streams:type=stream-thread-metrics,thread-id=([-.\w]+)</td>
+ </tr>
+ <tr>
+ <td>thread-state</td>
+ <td>The state of the thread as number (<code>ordinal()</code> of the
corresponding enum).</td>
Review Comment:
```suggestion
<td>The state of the thread as a number (<code>ordinal()</code> of
the corresponding enum).</td>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
