m1a2st commented on code in PR #18388:
URL: https://github.com/apache/kafka/pull/18388#discussion_r1903216950
##########
server/src/main/java/org/apache/kafka/network/SocketServerConfigs.java:
##########
@@ -65,17 +65,17 @@ public class SocketServerConfigs {
public static final String LISTENERS_CONFIG = "listeners";
public static final String LISTENERS_DEFAULT = "PLAINTEXT://:9092";
- public static final String LISTENERS_DOC = "Listener List -
Comma-separated list of URIs we will listen on and the listener names." +
- String.format(" If the listener name is not a security protocol,
<code>%s</code> must also be set.%n", LISTENER_SECURITY_PROTOCOL_MAP_CONFIG) +
- " Listener names and port numbers must be unique unless %n" +
- " one listener is an IPv4 address and the other listener is %n" +
- " an IPv6 address (for the same port).%n" +
- " Specify hostname as 0.0.0.0 to bind to all interfaces.%n" +
- " Leave hostname empty to bind to default interface.%n" +
- " Examples of legal listener lists:%n" +
- " <code>PLAINTEXT://myhost:9092,SSL://:9091</code>%n" +
- "
<code>CLIENT://0.0.0.0:9092,REPLICATION://localhost:9093</code>%n" +
- " <code>PLAINTEXT://127.0.0.1:9092,SSL://[::1]:9092</code>%n";
+ public static final String LISTENERS_DOC = String.format("Listener List -
Comma-separated list of URIs we will listen on and the listener names." +
+ " If the listener name is not a security protocol,
<code>%s</code> must also be set.%n" +
+ " Listener names and port numbers must be unique unless
%n" +
+ " one listener is an IPv4 address and the other listener
is %n" +
Review Comment:
nit This seems to be a complete sentence. Could you remove the line
separator?”
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
