cadonna commented on code in PR #18379: URL: https://github.com/apache/kafka/pull/18379#discussion_r1903927846
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/ChangelogTopics.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.streams.topics; + +import org.apache.kafka.common.errors.StreamsInvalidTopologyException; +import org.apache.kafka.common.utils.LogContext; +import org.apache.kafka.coordinator.group.generated.StreamsGroupTopologyValue.Subtopology; +import org.apache.kafka.coordinator.group.generated.StreamsGroupTopologyValue.TopicInfo; + +import org.slf4j.Logger; + +import java.util.Collection; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.OptionalInt; +import java.util.Set; +import java.util.function.Function; +import java.util.stream.Collectors; + +/** + * This class is responsible for setting up the changelog topics for a topology. + */ Review Comment: Could you please add some more details? ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/ChangelogTopics.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.streams.topics; + +import org.apache.kafka.common.errors.StreamsInvalidTopologyException; +import org.apache.kafka.common.utils.LogContext; +import org.apache.kafka.coordinator.group.generated.StreamsGroupTopologyValue.Subtopology; +import org.apache.kafka.coordinator.group.generated.StreamsGroupTopologyValue.TopicInfo; + +import org.slf4j.Logger; + +import java.util.Collection; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.OptionalInt; +import java.util.Set; +import java.util.function.Function; +import java.util.stream.Collectors; + +/** + * This class is responsible for setting up the changelog topics for a topology. + */ +public class ChangelogTopics { + + private final Logger log; + private final Collection<Subtopology> subtopologies; + private final Function<String, Integer> topicPartitionCountProvider; + + public ChangelogTopics( Review Comment: Could you please add javadocs? Especially for the `topicPartitionCountProvider`. ########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/ChangelogTopics.java: ########## @@ -0,0 +1,90 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group.streams.topics; + +import org.apache.kafka.common.errors.StreamsInvalidTopologyException; +import org.apache.kafka.common.utils.LogContext; +import org.apache.kafka.coordinator.group.generated.StreamsGroupTopologyValue.Subtopology; +import org.apache.kafka.coordinator.group.generated.StreamsGroupTopologyValue.TopicInfo; + +import org.slf4j.Logger; + +import java.util.Collection; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.OptionalInt; +import java.util.Set; +import java.util.function.Function; +import java.util.stream.Collectors; + +/** + * This class is responsible for setting up the changelog topics for a topology. + */ +public class ChangelogTopics { + + private final Logger log; + private final Collection<Subtopology> subtopologies; + private final Function<String, Integer> topicPartitionCountProvider; + + public ChangelogTopics( + final LogContext logContext, + final Collection<Subtopology> subtopologies, + final Function<String, Integer> topicPartitionCountProvider + ) { + this.log = logContext.logger(getClass()); + this.subtopologies = subtopologies; + this.topicPartitionCountProvider = topicPartitionCountProvider; + } + + /** + * Determines the number of partitions for each non-source changelog topic in the requested topology. + * + * @return the map of all non-source changelog topics for the requested topology to their required number of partitions. + */ + public Map<String, Integer> setup() { + final Map<String, Integer> changelogTopicPartitions = new HashMap<>(); + for (Subtopology subtopology : subtopologies) { + final Set<String> sourceTopics = new HashSet<>(subtopology.sourceTopics()); + + final OptionalInt maxNumPartitions = + subtopology.sourceTopics().stream().mapToInt(this::getPartitionCountOrFail).max(); + + if (maxNumPartitions.isEmpty()) { + throw new StreamsInvalidTopologyException("No source topics found for subtopology " + subtopology.subtopologyId()); + } + for (final TopicInfo topicInfo : subtopology.stateChangelogTopics()) { + if (!sourceTopics.contains(topicInfo.name())) { + changelogTopicPartitions.put(topicInfo.name(), maxNumPartitions.getAsInt()); + } + } + } + + log.debug("Expecting state changelog topic partitions {} for the requested topology.", + changelogTopicPartitions.entrySet().stream().map(e -> e.getKey() + ":" + e.getValue()).collect(Collectors.joining(", "))); + + return changelogTopicPartitions; + } + + private int getPartitionCountOrFail(String topic) { + final Integer topicPartitionCount = topicPartitionCountProvider.apply(topic); + if (topicPartitionCount == null) { Review Comment: Should the `topicPartitionCountProvider` return an `Optional` instead of an `Integer`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
