aoli-al opened a new pull request, #18405:
URL: https://github.com/apache/kafka/pull/18405

   
   *More detailed description of your change,
   if necessary. The PR title and PR message become
   the squashed commit message, so use a separate
   comment to ping reviewers.*
   
   This PR fixes KAFKA-18418. `KafkaStreams` can close completely even with 
`closeOptions.timeout(Duration.ZERO)` set due to concurrency issues. Thus, the 
test should check the return value of the `KafkaStreams::close` method before 
performing the assertions.  
   
   *Summary of testing strategy (including rationale)
   for the feature or bug fix. Unit and/or integration
   tests are expected for any behaviour change and
   system tests should be considered for larger changes.*
   
   I've rebased the proposed fix to the branch 
https://github.com/aoli-al/kafka/tree/KAFKA-159 and saw the test passes. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to