chia7712 commented on code in PR #18396:
URL: https://github.com/apache/kafka/pull/18396#discussion_r1904634091
##########
share-coordinator/src/main/java/org/apache/kafka/coordinator/share/ShareCoordinatorShard.java:
##########
@@ -206,15 +208,19 @@ public void replay(long offset, long producerId, short
producerEpoch, Coordinato
ApiMessageAndVersion key = record.key();
ApiMessageAndVersion value = record.value();
- switch (key.version()) {
- case ShareCoordinator.SHARE_SNAPSHOT_RECORD_KEY_VERSION: //
ShareSnapshot
- handleShareSnapshot((ShareSnapshotKey) key.message(),
(ShareSnapshotValue) messageOrNull(value), offset);
- break;
- case ShareCoordinator.SHARE_UPDATE_RECORD_KEY_VERSION: //
ShareUpdate
- handleShareUpdate((ShareUpdateKey) key.message(),
(ShareUpdateValue) messageOrNull(value));
- break;
- default:
- // Noop
+ try {
+ switch (CoordinatorRecordType.fromId(key.version())) {
+ case SHARE_SNAPSHOT:
+ handleShareSnapshot((ShareSnapshotKey) key.message(),
(ShareSnapshotValue) messageOrNull(value), offset);
+ break;
+ case SHARE_UPDATE:
+ handleShareUpdate((ShareUpdateKey) key.message(),
(ShareUpdateValue) messageOrNull(value));
+ break;
+ default:
+ // Noop
Review Comment:
maybe we can use java 17 enhanced switch to eliminate unnecessary default
branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
