kirktrue commented on code in PR #17669:
URL: https://github.com/apache/kafka/pull/17669#discussion_r1904738015
##########
tools/src/main/java/org/apache/kafka/tools/VerifiableConsumer.java:
##########
@@ -634,15 +634,15 @@ public static VerifiableConsumer
createFromArgs(ArgumentParser parser, String[]
}
}
- String groupProtocol = res.getString("groupProtocol");
+ GroupProtocol groupProtocol =
GroupProtocol.of(res.getString("groupProtocol"));
+ consumerProps.put(ConsumerConfig.GROUP_PROTOCOL_CONFIG,
groupProtocol.name());
Review Comment:
Reviewer note: this change ensures the specified group protocol is set in
the consumer configuration _regardless_ of its value. Before, the group
protocol was only set in the configuration when it was `CONSUMER`.
This minor issue came out of the testing of switching the group protocol
default from `CLASSIC` to `CONSUMER`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
