CalvinConfluent commented on code in PR #17952:
URL: https://github.com/apache/kafka/pull/17952#discussion_r1906166513
##########
metadata/src/main/java/org/apache/kafka/controller/FeatureControlManager.java:
##########
@@ -411,4 +412,12 @@ public void replay(FeatureLevelRecord record) {
boolean isControllerId(int nodeId) {
return quorumFeatures.isControllerId(nodeId);
}
+
+ boolean isElrFeatureEnabled() {
+ return
isElrFeatureEnabled(latestFinalizedFeatures().versionOrDefault(EligibleLeaderReplicasVersion.FEATURE_NAME,
(short) 0));
+ }
+
+ public static boolean isElrFeatureEnabled(short elrFeatureLevel) {
Review Comment:
We can remove this static method, no one uses it any more.
##########
metadata/src/main/java/org/apache/kafka/controller/ConfigurationControlManager.java:
##########
@@ -303,6 +339,14 @@ private ApiError validateAlterConfig(ConfigResource
configResource,
if (alterConfigPolicy.isPresent()) {
alterConfigPolicy.get().validate(new
RequestMetadata(configResource, alteredConfigsForAlterConfigPolicyCheck));
}
+ if (featureControl.isElrFeatureEnabled()) {
Review Comment:
We should remove this part as we have done the filtering above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
