jolshan commented on code in PR #18448:
URL: https://github.com/apache/kafka/pull/18448#discussion_r1907640306
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -854,7 +856,7 @@ synchronized TxnRequestHandler nextRequest(boolean
hasIncompleteBatches) {
return null;
}
- if (nextRequestHandler.isEndTxn() && (!isTransactionV2Enabled() &&
!transactionStarted)) {
+ if (nextRequestHandler.isEndTxn() && !transactionStarted) {
Review Comment:
minor nit here: I wonder if we can change the log here for tv2 so that we
say we didn't attempt to add any partitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
