chia7712 commented on code in PR #18408:
URL: https://github.com/apache/kafka/pull/18408#discussion_r1907642499
##########
storage/src/main/java/org/apache/kafka/storage/log/metrics/BrokerTopicMetrics.java:
##########
@@ -77,7 +76,6 @@ private BrokerTopicMetrics(Optional<String> name, boolean
remoteStorageEnabled)
metricTypeMap.put(FAILED_FETCH_REQUESTS_PER_SEC, new
MeterWrapper(FAILED_FETCH_REQUESTS_PER_SEC, "requests"));
metricTypeMap.put(TOTAL_PRODUCE_REQUESTS_PER_SEC, new
MeterWrapper(TOTAL_PRODUCE_REQUESTS_PER_SEC, "requests"));
metricTypeMap.put(TOTAL_FETCH_REQUESTS_PER_SEC, new
MeterWrapper(TOTAL_FETCH_REQUESTS_PER_SEC, "requests"));
- metricTypeMap.put(FETCH_MESSAGE_CONVERSIONS_PER_SEC, new
MeterWrapper(FETCH_MESSAGE_CONVERSIONS_PER_SEC, "requests"));
Review Comment:
Following the discussion with @ijuma, I believe we should add a deprecation
message to these metrics. Perhaps we could introduce a new tag to identify them
as deprecated?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
