TaiJuWu commented on code in PR #18432:
URL: https://github.com/apache/kafka/pull/18432#discussion_r1907659450
##########
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##########
@@ -830,78 +705,6 @@ class KafkaApisTest extends Logging {
.thenReturn(Seq(result).asJava)
}
- private def verifyAlterConfigResult(response: AlterConfigsResponse,
- expectedResults: Map[String, Errors]):
Unit = {
- val responseMap = response.data.responses().asScala.map { resourceResponse
=>
- resourceResponse.resourceName ->
Errors.forCode(resourceResponse.errorCode)
- }.toMap
-
- assertEquals(expectedResults, responseMap)
- }
-
- private def createConfigsWithAuthorization(authorizer: Authorizer,
- authorizedTopic: String,
- unauthorizedTopic: String):
(ConfigResource, ConfigResource) = {
- val authorizedResource = new ConfigResource(ConfigResource.Type.TOPIC,
authorizedTopic)
-
- val unauthorizedResource = new ConfigResource(ConfigResource.Type.TOPIC,
unauthorizedTopic)
-
- createTopicAuthorization(authorizer, AclOperation.ALTER_CONFIGS,
authorizedTopic, unauthorizedTopic)
- (authorizedResource, unauthorizedResource)
- }
-
- @Test
- def testIncrementalAlterConfigsWithAuthorizer(): Unit = {
Review Comment:
This test only work for zk so we can delete it.
All requests are forwarded to controller directly except log4j setting but
log4j request doesn’t redirect to controller.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
