ableegoldman commented on code in PR #18430:
URL: https://github.com/apache/kafka/pull/18430#discussion_r1907956445
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java:
##########
@@ -1075,12 +1077,14 @@ void runOnceWithoutProcessingThreads() {
pollRatioSensor.record((double) pollLatency / runOnceLatency, now);
commitRatioSensor.record((double) totalCommitLatency / runOnceLatency,
now);
- if (logSummaryIntervalMs > 0 && now - lastLogSummaryMs >
logSummaryIntervalMs) {
- log.info("Processed {} total records, ran {} punctuators, and
committed {} total tasks since the last update",
- totalRecordsProcessedSinceLastSummary,
totalPunctuatorsSinceLastSummary, totalCommittedSinceLastSummary);
+ final long timeSinceLastLog = now - lastLogSummaryMs;
+ if (logSummaryIntervalMs > 0 && timeSinceLastLog >
logSummaryIntervalMs) {
+ log.info("Processed {} total records, ran {} punctuators, polled
{} times and committed {} total tasks since the last update {}ms ago",
Review Comment:
can we also log how long it's been since the last update? we just merged a
KIP to allow configuring this interval, and anyways the time can vary and the
logging interval is just a minimum not exact interval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
