chia7712 commented on code in PR #18450:
URL: https://github.com/apache/kafka/pull/18450#discussion_r1908070818
##########
core/src/main/scala/kafka/zk/KafkaZkClient.scala:
##########
@@ -53,28 +37,9 @@ import scala.jdk.CollectionConverters._
* easier to migrate away from `ZkUtils` (since removed). We should revisit
this. We should also consider whether a
* monolithic [[kafka.zk.ZkData]] is the way to go.
*/
-class KafkaZkClient private[zk] (
- zooKeeperClient: ZooKeeperClient,
- isSecure: Boolean,
- time: Time,
- enableEntityConfigControllerCheck: Boolean
-) extends AutoCloseable with Logging {
-
- private val metricsGroup: KafkaMetricsGroup = new
KafkaMetricsGroup("kafka.server", "ZooKeeperClientMetrics")
Review Comment:
@m1a2st please include those removed zk-related metrics in #18365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
