chia7712 commented on code in PR #18445:
URL: https://github.com/apache/kafka/pull/18445#discussion_r1908113186
##########
clients/src/main/java/org/apache/kafka/common/requests/FetchResponse.java:
##########
@@ -203,8 +203,7 @@ public static FetchResponseData.PartitionData
partitionResponse(int partition, E
* Returns `partition.records` as `Records` (instead of `BaseRecords`). If
`records` is `null`, returns `MemoryRecords.EMPTY`.
*
* If this response was deserialized after a fetch, this method should
never fail. An example where this would
- * fail is a down-converted response (e.g. LazyDownConversionRecords) on
the broker (before it's serialized and
- * sent on the wire).
+ * fail is a down-converted response on the broker (before it's serialized
and sent on the wire).
Review Comment:
the message conversion has been removed by #18218, so this comment is stale.
could you please remove it?
##########
clients/src/main/java/org/apache/kafka/common/requests/ShareFetchResponse.java:
##########
@@ -124,8 +124,7 @@ public static ShareFetchResponse parse(ByteBuffer buffer,
short version) {
* Returns `partition.records` as `Records` (instead of `BaseRecords`). If
`records` is `null`, returns `MemoryRecords.EMPTY`.
*
* <p>If this response was deserialized after a share fetch, this method
should never fail. An example where this would
- * fail is a down-converted response (e.g. LazyDownConversionRecords) on
the broker (before it's serialized and
- * sent on the wire).
+ * fail is a down-converted response on the broker (before it's serialized
and sent on the wire).
Review Comment:
ditto
##########
clients/src/main/java/org/apache/kafka/common/record/MultiRecordsSend.java:
##########
@@ -125,17 +123,4 @@ public String toString() {
", totalWritten=" + totalWritten +
')';
}
-
- private void updateRecordConversionStats(Send completedSend) {
- // The underlying send might have accumulated statistics that need to
be recorded. For example,
- // LazyDownConversionRecordsSend accumulates statistics related to the
number of bytes down-converted, the amount
- // of temporary memory used for down-conversion, etc. Pull out any
such statistics from the underlying send
- // and fold it up appropriately.
- if (completedSend instanceof LazyDownConversionRecordsSend) {
- if (recordConversionStats == null)
Review Comment:
we can remove recordConversionStats and recordConversionStats(), right?
##########
docs/upgrade.html:
##########
@@ -75,6 +75,8 @@ <h5><a id="upgrade_400_notable"
href="#upgrade_400_notable">Notable changes in 4
</li>
<li>The function <code>onNewBatch</code> in
<code>org.apache.kafka.clients.producer.Partitioner</code> class was removed.
</li>
+ <li>The
<code>org.apache.kafka.common.record.LazyDownConversionRecords</code> class and
<code>org.apache.kafka.common.record.LazyDownConversionRecordsSend</code> class
were removed.
Review Comment:
they are not public APIs so we don't need to add them into upgrade.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
