chia7712 commented on code in PR #18437:
URL: https://github.com/apache/kafka/pull/18437#discussion_r1908115933
##########
core/src/main/scala/kafka/server/NodeToControllerChannelManager.scala:
##########
@@ -52,37 +51,6 @@ trait ControllerNodeProvider {
def getControllerInfo(): ControllerInformation
}
-class MetadataCacheControllerNodeProvider(
- val metadataCache: ZkMetadataCache,
- val config: KafkaConfig,
- val quorumControllerNodeProvider: () => Option[ControllerInformation]
-) extends ControllerNodeProvider {
-
- private val zkControllerListenerName = config.interBrokerListenerName
- private val zkControllerSecurityProtocol = config.interBrokerSecurityProtocol
- private val zkControllerSaslMechanism =
config.saslMechanismInterBrokerProtocol
-
- val emptyZkControllerInfo = ControllerInformation(
- None,
- zkControllerListenerName,
- zkControllerSecurityProtocol,
- zkControllerSaslMechanism,
- isZkController = true)
Review Comment:
Could you please remove `isZkController` and
`isNetworkClientForZkController` from this class file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
