adixitconfluent commented on code in PR #17870:
URL: https://github.com/apache/kafka/pull/17870#discussion_r1908709628
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -312,7 +323,7 @@ private boolean
isMinBytesSatisfied(LinkedHashMap<TopicIdPartition, FetchRequest
return true;
} else if
(fetchOffsetMetadata.onSameSegment(endOffsetMetadata)) {
// we take the partition fetch size as upper bound when
accumulating the bytes.
- long bytesAvailable =
Math.min(endOffsetMetadata.positionDiff(fetchOffsetMetadata),
partitionData.maxBytes);
+ long bytesAvailable =
Math.min(endOffsetMetadata.positionDiff(fetchOffsetMetadata),
shareFetch.fetchParams().maxBytes / topicPartitionData.size());
Review Comment:
you're right, it is incorrect. I missed this refactor when I was writing the
`PartitionMaxBytesStrategy` class, I will correct it in my next commit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
