dajac commented on code in PR #18461:
URL: https://github.com/apache/kafka/pull/18461#discussion_r1908955860
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -508,12 +508,8 @@ class KafkaApis(val requestChannel: RequestChannel,
CompletableFuture.completedFuture(())
} else if (request.header.apiVersion == 0) {
// For version 0, always store offsets in ZK.
- commitOffsetsToZookeeper(
- request,
- offsetCommitRequest,
- authorizedTopicsRequest,
- responseBuilder
- )
+ requestHelper.sendMaybeThrottle(request,
offsetCommitRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
Review Comment:
I think that we removed version 0 of that API so we could remove the entire
branch.
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -1230,58 +1191,13 @@ class KafkaApis(val requestChannel: RequestChannel,
def handleOffsetFetchRequest(request: RequestChannel.Request):
CompletableFuture[Unit] = {
val version = request.header.apiVersion
if (version == 0) {
- handleOffsetFetchRequestFromZookeeper(request)
+ requestHelper.sendMaybeThrottle(request,
request.body[OffsetFetchRequest].getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
+ CompletableFuture.completedFuture(())
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
