ijuma commented on code in PR #18414:
URL: https://github.com/apache/kafka/pull/18414#discussion_r1909310036
##########
server/src/main/java/org/apache/kafka/server/config/KRaftConfigs.java:
##########
@@ -125,7 +124,7 @@ public class KRaftConfigs {
public static final ConfigDef CONFIG_DEF = new ConfigDef()
.define(METADATA_SNAPSHOT_MAX_NEW_RECORD_BYTES_CONFIG, LONG,
METADATA_SNAPSHOT_MAX_NEW_RECORD_BYTES, atLeast(1), HIGH,
METADATA_SNAPSHOT_MAX_NEW_RECORD_BYTES_DOC)
.define(METADATA_SNAPSHOT_MAX_INTERVAL_MS_CONFIG, LONG,
METADATA_SNAPSHOT_MAX_INTERVAL_MS_DEFAULT, atLeast(0), HIGH,
METADATA_SNAPSHOT_MAX_INTERVAL_MS_DOC)
- .define(PROCESS_ROLES_CONFIG, LIST, Collections.emptyList(),
ConfigDef.ValidList.in("broker", "controller"), HIGH, PROCESS_ROLES_DOC)
+ .define(PROCESS_ROLES_CONFIG, LIST, List.of("broker"),
ConfigDef.ValidList.in("broker", "controller"), HIGH, PROCESS_ROLES_DOC)
Review Comment:
Let's make sure the error message is also good when the config isn't
provided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
