chia7712 commented on code in PR #18447:
URL: https://github.com/apache/kafka/pull/18447#discussion_r1909772013
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3025,36 +3025,7 @@ class KafkaApis(val requestChannel: RequestChannel,
}
def handleRenewTokenRequestZk(request: RequestChannel.Request): Unit = {
Review Comment:
ditto
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3071,36 +3042,7 @@ class KafkaApis(val requestChannel: RequestChannel,
}
def handleExpireTokenRequestZk(request: RequestChannel.Request): Unit = {
Review Comment:
Maybe we can remove this method to remove "zk" from this class? in the
line#3040 we can rewrite it to `maybeForwardToController(request,
KafkaApis.shouldAlwaysForward)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
