mingdaoy commented on code in PR #18454:
URL: https://github.com/apache/kafka/pull/18454#discussion_r1909250519
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2620,13 +2620,11 @@ class KafkaApis(val requestChannel: RequestChannel,
}
def handleCreateAcls(request: RequestChannel.Request): Unit = {
- metadataSupport.requireZkOrThrow(KafkaApis.shouldAlwaysForward(request))
- aclApis.handleCreateAcls(request)
+ throw KafkaApis.shouldNeverReceive(request)
}
def handleDeleteAcls(request: RequestChannel.Request): Unit = {
- metadataSupport.requireZkOrThrow(KafkaApis.shouldAlwaysForward(request))
- aclApis.handleDeleteAcls(request)
+ throw KafkaApis.shouldNeverReceive(request)
Review Comment:
Should it be `throw KafkaApis.shouldAlwaysForward(request)` instead?
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2620,13 +2620,11 @@ class KafkaApis(val requestChannel: RequestChannel,
}
def handleCreateAcls(request: RequestChannel.Request): Unit = {
- metadataSupport.requireZkOrThrow(KafkaApis.shouldAlwaysForward(request))
- aclApis.handleCreateAcls(request)
+ throw KafkaApis.shouldNeverReceive(request)
Review Comment:
Should it be `throw KafkaApis.shouldAlwaysForward(request)` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
