[ https://issues.apache.org/jira/browse/KAFKA-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16702045#comment-16702045 ]
ASF GitHub Bot commented on KAFKA-7671: --------------------------------------- bbejeck opened a new pull request #5959: KAFKA-7671: Stream-Global Table join should not reset repartition flag URL: https://github.com/apache/kafka/pull/5959 This PR fixes an issue reported from a user. When we join a `KStream` with a `GlobalKTable` we should not reset the repartition flag as the stream may have previously changed its key, and the resulting stream could be used in an aggregation operation or join with another stream which may require a repartition for correct results. I've added a test which fails without the fix. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > A KStream/GlobalKTable join shouldn't reset the repartition flag > ---------------------------------------------------------------- > > Key: KAFKA-7671 > URL: https://issues.apache.org/jira/browse/KAFKA-7671 > Project: Kafka > Issue Type: Improvement > Components: streams > Affects Versions: 2.0.1 > Reporter: Andy Bryant > Assignee: Bill Bejeck > Priority: Major > Fix For: 2.2.0, 2.1.1 > > > Currently a KStream/GlobalKTable join resets the repartition required flag to > false. > I have a topology where I map a stream, join with a GlobalKTable, then > groupByKey then aggregate. > The aggregate wasn't behaving correctly because it didn't force a repartition > as I expected. The KStream/GlobalKTable join had reset the flag and hence I > was getting the same keys in different partitions. > Since a KStream/GlobalKTable join does not itself force a repartition, it > should simply propagate the flag down to the resultant KStream the same way > most other operators work. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)