dajac commented on PR #18458: URL: https://github.com/apache/kafka/pull/18458#issuecomment-2581931683
> LGTM > > I originally want to say "could you please add unit tests for those converters", but it seems other converts have no test also - maybe adding unit tests can be follow-up. Yeah, it is not easy to have unit tests for those as they generate files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
