ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1910495469
##########
core/src/test/scala/unit/kafka/coordinator/group/GroupMetadataManagerTest.scala:
##########
@@ -2593,45 +2574,12 @@ class GroupMetadataManagerTest {
time.milliseconds(),
OptionalLong.of(time.milliseconds() + 1000))
- def verifySerde(metadataVersion: MetadataVersion): Unit = {
- val bytes = GroupMetadataManager.offsetCommitValue(offsetAndMetadata,
metadataVersion)
- val buffer = ByteBuffer.wrap(bytes)
- assertEquals(1, buffer.getShort(0).toInt)
-
- val deserializedOffsetAndMetadata =
GroupMetadataManager.readOffsetMessageValue(buffer)
- assertEquals(offsetAndMetadata, deserializedOffsetAndMetadata)
- }
-
- for (version <- MetadataVersion.VERSIONS)
- verifySerde(version)
- }
-
- @Test
- def testSerdeOffsetCommitValueWithNoneExpireTimestamp(): Unit = {
Review Comment:
This basically duplicates `testSerdeOffsetCommitValue` and hence I removed
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
