ijuma commented on code in PR #18468:
URL: https://github.com/apache/kafka/pull/18468#discussion_r1911287231


##########
core/src/main/scala/kafka/server/ApiVersionManager.scala:
##########
@@ -150,14 +150,12 @@ class DefaultApiVersionManager(
     }
     val apiVersions = if (controllerApiVersions.isDefined) {
       ApiVersionsResponse.controllerApiVersions(
-        finalizedFeatures.metadataVersion().highestSupportedRecordVersion,

Review Comment:
   I can revert this (and related code) if you think it's useful since it's 
reasonably self-contained. The benefit of keeping vs removing is probably 
borderline given that there are no concrete plans for adding new record 
versions (including the specifics regarding the compatibility story). Still, 
this is a bit unrelated to the main point of this PR (MV/IBP), so I can change 
it back.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to