jolshan commented on code in PR #18467:
URL: https://github.com/apache/kafka/pull/18467#discussion_r1911701912
##########
core/src/main/scala/kafka/coordinator/transaction/TransactionCoordinator.scala:
##########
@@ -814,10 +814,10 @@ class TransactionCoordinator(txnConfig: TransactionConfig,
if (txnMetadata.producerId != producerId && !retryOnOverflow)
Left(Errors.INVALID_PRODUCER_ID_MAPPING)
- else if (!isValidEpoch)
- Left(Errors.PRODUCER_FENCED)
else if (txnMetadata.pendingTransitionInProgress &&
txnMetadata.pendingState.get != PrepareEpochFence)
Left(Errors.CONCURRENT_TRANSACTIONS)
+ else if (!isValidEpoch)
+ Left(Errors.PRODUCER_FENCED)
Review Comment:
exactly! We will retry until the previous operation completes and then we
can handle the abort. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]