dajac commented on code in PR #18480:
URL: https://github.com/apache/kafka/pull/18480#discussion_r1912971085
##########
core/src/main/scala/kafka/tools/DumpLogSegments.scala:
##########
@@ -519,41 +483,11 @@ object DumpLogSegments {
json
}
- private def prepareValue(message: Message, version: Short): String = {
- val messageAsJson = message match {
- case m: OffsetCommitValue =>
- OffsetCommitValueJsonConverter.write(m, version)
- case m: GroupMetadataValue =>
- prepareGroupMetadataValue(m, version)
- case m: ConsumerGroupMetadataValue =>
- ConsumerGroupMetadataValueJsonConverter.write(m, version)
- case m: ConsumerGroupPartitionMetadataValue =>
- ConsumerGroupPartitionMetadataValueJsonConverter.write(m, version)
- case m: ConsumerGroupMemberMetadataValue =>
- ConsumerGroupMemberMetadataValueJsonConverter.write(m, version)
- case m: ConsumerGroupTargetAssignmentMetadataValue =>
- ConsumerGroupTargetAssignmentMetadataValueJsonConverter.write(m,
version)
- case m: ConsumerGroupTargetAssignmentMemberValue =>
- ConsumerGroupTargetAssignmentMemberValueJsonConverter.write(m,
version)
- case m: ConsumerGroupCurrentMemberAssignmentValue =>
- ConsumerGroupCurrentMemberAssignmentValueJsonConverter.write(m,
version)
- case m: ConsumerGroupRegularExpressionValue =>
- ConsumerGroupRegularExpressionValueJsonConverter.write(m, version)
- case m: ShareGroupMetadataValue =>
- ShareGroupMetadataValueJsonConverter.write(m, version)
- case m: ShareGroupPartitionMetadataValue =>
- ShareGroupPartitionMetadataValueJsonConverter.write(m, version)
- case m: ShareGroupMemberMetadataValue =>
- ShareGroupMemberMetadataValueJsonConverter.write(m, version)
- case m: ShareGroupTargetAssignmentMetadataValue =>
- ShareGroupTargetAssignmentMetadataValueJsonConverter.write(m,
version)
- case m: ShareGroupTargetAssignmentMemberValue =>
- ShareGroupTargetAssignmentMemberValueJsonConverter.write(m, version)
- case m: ShareGroupCurrentMemberAssignmentValue =>
- ShareGroupCurrentMemberAssignmentValueJsonConverter.write(m, version)
- case m: ShareGroupStatePartitionMetadataValue =>
- ShareGroupStatePartitionMetadataValueJsonConverter.write(m, version)
- case _ => throw new IllegalStateException(s"Message value
${message.getClass.getSimpleName} is not supported.")
+ private def prepareValue(message: ApiMessage, version: Short): String = {
+ val messageAsJson = if (message.apiKey ==
GroupCoordinatorRecordType.GROUP_METADATA.id) {
+ prepareGroupMetadataValue(message.asInstanceOf[GroupMetadataValue],
version)
Review Comment:
Yeah, but this is true with and without this change. `GroupMetadataValue` is
annoying because it requires a special handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
